-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Storing basic provenance on JSON sidecars of derivatives #300
[ENH] Storing basic provenance on JSON sidecars of derivatives #300
Conversation
…fields from BEP16 Mapped from @Lestropie's bids-standard/bids-bep016#5 Closes bids-standard/bids-bep016#2 I have removed some keys that I believe should remain in BEP16 for being applicable to dwi only. I have also changed _FieldInhomogeneity*_ with _SusceptibilityDistortion*_ since I think the latter will be more familiar to a wider audience.
cc/ @bids-standard/derivatives-mri-dwi |
Since this is common derivatives, we should be pinging @bids-standard/derivatives. These questions in particular are relevant to @bids-standard/derivatives-mri, but there has been discussion (apologies for not linking at the moment; I'll try to find it) with @bids-standard/derivatives-electrophys that I guess I would say that either we should merge this quickly and address the MRI-centricity in #265, or address it there first, and hold off on this until that's resolved. |
I don't think that any datatype specific metadata fields should be required as per common-derivatives. |
I drafted this PR to move out the discussion from BEP16, as we felt we were talking about metadata that could easily be present in other MRI derivatives. That said, my opinion is that we should remove all these metadata bits for two reasons:
I'm fine either way, but if |
1a7d012
to
c200cff
Compare
@oesteban this PR is still marked for the common derivatives milestone. How do you want to proceed with this PR? Can it be closed? Should it become an issue for further discussion? Some other idea? |
Sure, what's the course of action regarding BEP016? Should we just remove mentions to these provenance entries? |
Summary
In the context of BEP 016 we found ourselves prescribing what metadata fields should/could be included within derivatives. We then realized that some of them would easily extend to other Imaging derivatives (see #310), and also tapped on the quite controversial
SkullStripped
metadata field.Proposal
Since BIDS has always been reluctant to include much provenance information, this PR proposes to make all these metadata fields OPTIONAL, and provides some suggestions for naming.
Original Content of this PR
Mapped from @Lestropie's bids-standard/bids-bep016#5
Closes bids-standard/bids-bep016#2
I have removed some keys that I believe should remain in BEP16 for being
applicable to dwi only.
I have also changed FieldInhomogeneity* with
SusceptibilityDistortion* since I think the latter will be more
familiar to a wider audience.
EDIT: fields that remained in BEP16 are -
EddyCurrentCorrection
,GradientNonLinearityQSpaceCorrection
,SliceDropoutDetection
,SliceDropoutReplacement