Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Clarify phenotypic and assessment data in new section #331

Merged
merged 3 commits into from
Sep 23, 2019
Merged

[ENH] Clarify phenotypic and assessment data in new section #331

merged 3 commits into from
Sep 23, 2019

Conversation

sappelhoff
Copy link
Member

closes #280

  • make "phenotype" data its own section instead of a subsection of "participants"
  • clarify WHERE to place the file, and how to name them
  • be more consistent with using MUST, SHOULD, ...

effigies
effigies reviewed Sep 13, 2019
View reviewed changes
src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
sappelhoff and others added 2 commits September 14, 2019 16:36
@sappelhoff @effigies
Apply suggestions from code review
8a2e467 
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
@sappelhoff @effigies
Update src/03-modality-agnostic-files.md
2093270 
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
effigies
effigies approved these changes Sep 18, 2019
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Anybody else? @bids-standard/raw

@effigies effigies changed the title [FIX] make phenotype data its own section and clarify usage [ENH] Clarify phenotypic and assessment data in new section Sep 18, 2019
teonbrooks
teonbrooks approved these changes Sep 18, 2019
View reviewed changes
Copy link
Collaborator

@teonbrooks teonbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@robertoostenveld
Copy link
Collaborator

LGTM.

Anybody else? @bids-standard/raw

looks good to me.

@sappelhoff sappelhoff merged commit 4c430f3 into bids-standard:master Sep 23, 2019
@sappelhoff sappelhoff deleted the pheno branch September 23, 2019 10:12
@sappelhoff
Copy link
Member Author

thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teonbrooks teonbrooks teonbrooks approved these changes

@effigies effigies effigies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples for use of "phenotype" saving survey data in BIDS
4 participants
@sappelhoff @robertoostenveld @effigies @teonbrooks