[INFRA] Find npm requirements file in Circle #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Sep 19, 2019
| @@ -90,7 +90,7 @@ jobs: | |||
| name: get remark styles | |||
| command: | | |||
| cd ~ | |||
| cat ~/build/npm-requirements.txt | xargs npm install | |||
| cat ~/project/npm-requirements.txt | xargs npm install | |||
There was a problem hiding this comment.
It doesn't look like there will be anything in ~/project? This doesn't make much sense to me.
There was a problem hiding this comment.
I just checked running the ssh on 1326 and there is a project folder. This folder is created at checkout
There was a problem hiding this comment.
~/project is the default CircleCI working directory, search for it (ctrl+f) on this page: https://circleci.com/docs/2.0/configuration-reference/
if you tested this and it works, this seems fine to me
sappelhoff
approved these changes
Sep 23, 2019
effigies
approved these changes
Sep 24, 2019
effigies
changed the title
franklin-feingold
added a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing: https://circleci.com/gh/bids-standard/bids-specification/1326
tested on CircleCI and the directory is correct to pull our style guides
note: the other failed tests appear to be from the quick succession of merged PRs (parallel running)