[INFRA] change plugin to remark-preset-lint-markdown-style-guide #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
approved these changes
Oct 22, 2019
|
thank you @mattcieslak for raising this - perhaps what may have motivated changing the linter? |
|
I don't know, actually. I'm not familiar with how node works, but this fixes an error I was seeing when trying to build this locally and on travis. It came up during #352 (comment) |
|
our linter can sometimes be challenging to get the enhancement to conform - we added a section in our Contributing guide for addressing these type of errors |
sappelhoff
approved these changes
Oct 23, 2019
|
Turns out this was only needed locally. Sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin was causing the travis build to fail.