Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add part entity for complex-valued data #424

Merged
merged 40 commits into from
Nov 23, 2020
Merged

[ENH] Add part entity for complex-valued data #424

merged 40 commits into from
Nov 23, 2020

Commits on Feb 24, 2020

  1. Add part entity.

    @tsalo
    tsalo committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    d9d2324 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Add self to contributors file.

    @tsalo
    tsalo committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    35c0253 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Address @yarikoptic's review.

    @tsalo
    tsalo committed May 4, 2020
    Configuration menu
    Copy the full SHA
    239c338 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Fix entity table spacing.

    @tsalo
    tsalo committed May 5, 2020
    Configuration menu
    Copy the full SHA
    82f60fd View commit details
    Browse the repository at this point in the history

  2. Add missing OPTIONAL for part under func (bold phase).

    @tsalo
    tsalo committed May 5, 2020
    Configuration menu
    Copy the full SHA
    6bcc2a5 View commit details
    Browse the repository at this point in the history

  3. Fix spacing again.

    @tsalo
    tsalo committed May 5, 2020
    Configuration menu
    Copy the full SHA
    69ea608 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Remove OPTIONAL under func (bold phase). Wasn't missing.

    @tsalo
    tsalo committed May 6, 2020
    Configuration menu
    Copy the full SHA
    2f67010 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Fix entity order (part goes after run).

    @tsalo
    tsalo committed May 18, 2020
    Configuration menu
    Copy the full SHA
    3c222d1 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Merge branch 'master' into enh/part-entity

    @tsalo
    tsalo authored May 20, 2020
    Configuration menu
    Copy the full SHA
    eca38ef View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. Merge branch 'master' into enh/part-entity

    @tsalo
    tsalo authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    2f65a94 View commit details
    Browse the repository at this point in the history

  2. Fix typo.

    @tsalo
    tsalo committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    908bdba View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Merge branch 'master' into enh/part-entity

    @tsalo
    tsalo committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    6d376e4 View commit details
    Browse the repository at this point in the history

  2. Incorporate part into schema.

    @tsalo
    tsalo committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    3ca9763 View commit details
    Browse the repository at this point in the history

  3. Update definition and examples to match BEP001.

    @tsalo
    tsalo committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    f566cf4 View commit details
    Browse the repository at this point in the history

  4. Fix code snippets.

    @tsalo
    tsalo committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    d6dc2ac View commit details
    Browse the repository at this point in the history

  5. Fix filename patterns now that real/imag is supported.

    @tsalo
    tsalo committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    8db0dea View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Apply suggestions from code review 

    - Change radians to rad.
- Treat `part` like `run`. Can only be omitted if only magnitude image is provided.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @tsalo @effigies
    tsalo and effigies authored Sep 1, 2020
    Configuration menu
    Copy the full SHA
    85957a3 View commit details
    Browse the repository at this point in the history

  2. Support part with BOLD and update entity table.

    @tsalo
    tsalo committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    0a88998 View commit details
    Browse the repository at this point in the history

  3. Update src/04-modality-specific-files/01-magnetic-resonance-imaging-d… 

    …ata.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @tsalo @effigies
    tsalo and effigies authored Sep 1, 2020
    Configuration menu
    Copy the full SHA
    08a0934 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Merge branch 'master' into enh/part-entity

    @tsalo
    tsalo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    01df45c View commit details
    Browse the repository at this point in the history

  2. Update entity table and entity definitions.

    @tsalo
    tsalo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c46715f View commit details
    Browse the repository at this point in the history

  3. Add link in text.

    @tsalo
    tsalo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    44a1a35 View commit details
    Browse the repository at this point in the history

  4. Remove section header.

    @tsalo
    tsalo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    8561f4a View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Address review.

    @tsalo
    tsalo committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    78aad5a View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Merge branch 'master' into enh/part-entity

    @tsalo
    tsalo authored Oct 2, 2020
    Configuration menu
    Copy the full SHA
    7655333 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2020

  1. Update src/04-modality-specific-files/01-magnetic-resonance-imaging-d… 

    …ata.md
    @tsalo
    tsalo authored Oct 3, 2020
    Configuration menu
    Copy the full SHA
    eb1f95f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Deprecate phase suffix.

    @tsalo
    tsalo committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    e0ffe84 View commit details
    Browse the repository at this point in the history

  2. Fix link.

    @tsalo
    tsalo committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    d800c09 View commit details
    Browse the repository at this point in the history

  3. Fix link again.

    @tsalo
    tsalo committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    9027334 View commit details
    Browse the repository at this point in the history

  4. Include deprecation in table.

    @tsalo
    tsalo committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    a8f54a1 View commit details
    Browse the repository at this point in the history

  5. Fix table.

    @tsalo
    tsalo committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    f04f195 View commit details
    Browse the repository at this point in the history

  6. Update 01-magnetic-resonance-imaging-data.md

    @tsalo
    tsalo committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    72800d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @tsalo @effigies
    tsalo and effigies authored Nov 16, 2020
    Configuration menu
    Copy the full SHA
    28abc54 View commit details
    Browse the repository at this point in the history

  2. Add entity field.

    @tsalo
    tsalo committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    5903d5d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into enh/part-entity

    @tsalo
    tsalo committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    cde2337 View commit details
    Browse the repository at this point in the history

  4. Fix bug and generate appendix.

    @tsalo
    tsalo committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    21aed29 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Fix table.

    @tsalo
    tsalo committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    e914b91 View commit details
    Browse the repository at this point in the history

  2. Update src/04-modality-specific-files/01-magnetic-resonance-imaging-d… 

    …ata.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @tsalo @effigies
    tsalo and effigies authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    903324b View commit details
    Browse the repository at this point in the history

  3. Improve part definition.

    @tsalo
    tsalo committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    78e70ef View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Merge branch 'master' into enh/part-entity

    @effigies
    effigies authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    a68fc79 View commit details
    Browse the repository at this point in the history