Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Clarify indices are nonnegative integers. #535

Merged
merged 8 commits into from
Aug 24, 2020
Merged

[FIX] Clarify indices are nonnegative integers. #535

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
51bb58d
Rule-out 0 as an index value
nicholst Jul 22, 2020
7202175
Replace 'natural number' with 'positive integers'
nicholst Jul 22, 2020
6ee0cc5
Make 1-indexing recommended
nicholst Jul 29, 2020
1c52b1d
Fix grammar (an -> a) & and 'positive'
nicholst Jul 31, 2020
66219d7
add line breaks
sappelhoff Aug 2, 2020
27795bd
Remove recommendation of 1-indexing
nicholst Aug 17, 2020
28713b1
Fussy edits to minimise diffs
nicholst Aug 17, 2020
9f6ede3
Update src/04-modality-specific-files/01-magnetic-resonance-imaging-d…
nicholst Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,8 @@ modalities include:

#### The `run` entity

If several scans of the same modality are acquired they MUST be indexed with a
key-value pair: `_run-1`, `_run-2`, `_run-3` etc. (only integers are allowed as
run labels). When there is only one scan of a given type the run key MAY be
omitted. Please note that diffusion imaging data is stored elsewhere (see
below).
If several scans of the same modality are acquired they MUST be indexed with a key-value pair: `_run-1`, `_run-2`, `_run-3` etc. (only positive integers are allowed as run labels, with indexing starting from 1 RECOMMENDED). When there is only one scan of a given type the run key MAY be omitted.
Please note that diffusion imaging data is stored elsewhere (see below).
sappelhoff marked this conversation as resolved.
Show resolved Hide resolved

#### The `acq` entity

Expand Down Expand Up @@ -263,8 +260,7 @@ sub-01/
sub-01_task-cuedSGT_run-1_echo-3_bold.json
```

Please note that the `<index>` denotes the number/index (in a form of an
integer) of the echo not the echo time value which needs to be stored in the
Please note that the `<index>` denotes the number/index (in a form of a positive integer, with indexing starting from 1 RECOMMENDED) of the echo not the echo time value which needs to be stored in the
sappelhoff marked this conversation as resolved.
Show resolved Hide resolved
field EchoTime of the separate JSON file.

Some meta information about the acquisition MUST be provided in an additional
Expand Down