-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Extend date time information to include optional UTC syntax, warn about FIF requirements #546
Conversation
I now also link to the
while doing that, I found the following sentence:
repeated across the files. For now I dropped it from the three files and added it to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor edits, but it looks good to me.
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very minor suggestions.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @sappelhoff
In https://github.com/bids-standard/bids-validator/pull/1019 I wanted to add the validation of the newly introduced "fractional seconds" that we allow for
AcquisitionTime
inscans.tsv
files.While discussing that code, we stumbled over potential incongruencies between RFC3339 and the way that standard is implemented in BIDS.
In this PR we may clarify/fix some aspects ... or in the least we'll add a link and fix a typo (see
de4ab9f )
EDIT: we are now adding optional
Z
syntax to indicate UTC time in accordance with RFC3339Z
syntax