-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add optional presentation software name, version, OS, and code to events.json #573
[ENH] add optional presentation software name, version, OS, and code to events.json #573
Conversation
@bids-standard/bep_leads please review this proposal |
I like the proposal. I do believe that
Yes, I think it should. However, there is more information missing from behavioural-only datasets, e.g. |
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
Outdated
Show resolved
Hide resolved
Good point. Will update. |
- change stimuli to stimulus - remove additional : - add comma
I believe all of this should be part of another PR, no? |
Indeed. I think that PR should consolidate Task Events (5) and Behavioural experiments (7) and make Behavioural data a first-class citizen. |
Agree with @robertoostenveld that the repetition of the Behavioural data descriptions is not good, but not sure what making it a first-class citizen entails. Would all Behavioural data for all modalities live in "Modality specific files -> Behavioral data"? |
I also don't know what it would entail but know that according to the spect "behaviour without fMRI" (and also without MEG, EEG and IEEG) is now allowed to be stored in a BIDS dataset. However, that now results in a very underspecified dataset with hardly any metadata. It would be relevant to consider how the relation of behavioural data to functional/biological data is optional, as is the joint (whether simultaneous or not) recording of multiple other data types (e.g. MEG with an anatomical MRI). This is a discussion (on "multi-modal") we had before on the mailing list but that has not resulted in visible improvements to the specification. But I think that this discussion falls outside the scope of this PR and might better be discussed in the format of a full-fledged BEP. |
I agree. So we "just" need a volunteer to take the lead on that... |
note that there is a parallel effort called Psych-DS (
https://psych-ds.github.io/) that is working on a BIDS-like spec for
behavioral data. so before going down the road of a full-on BEP we should
consider whether we might instead try to adapt Psych-DS or at least work in
parallel so that our efforts are aligned.
…On Mon, Aug 17, 2020 at 4:22 AM Remi Gau ***@***.***> wrote:
But I think that this discussion falls outside the scope of this PR and
might better be discussed in the format of a full-fledged BEP.
I agree. So we "just" need a volunteer to take the lead on that...
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#573 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGUVEGDMRBIK73VSL4CBWDSBEHIDANCNFSM4QAIJ7VA>
.
--
Russell A. Poldrack
Albert Ray Lang Professor of Psychology
Building 420
Stanford University
Stanford, CA 94305
poldrack@stanford.edu
http://www.poldracklab.org/
|
Yup I keep thinking of psych-DS every time we talk about behavior-BIDS. The way I would see the behavioral support in BIDS would have to be very minimalist IMHO and simply make sure that for example things that are included in all the JSON of all other modalities, should make be also supported for the behavior-BIDS. But might be worth even just clarify that amongst us and with Psych-DS. |
Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
Strong +1 from me.
I think this makes sense. But having a conversation earlier than later with PsychDS might be helpful, too. For example, the set of minimal meta-data we'd want for movie-watching stimuli (like the EAN of the used DVD) will be very different than for a standard cognitive task. And it's not an uncommon use case for BIDS ! |
looping in @mekline to start the conversation |
Hi all, thanks for tagging me in. I would be very open to making PsychDS work well for BIDS, or otherwise aligning as far as possible! PsychDS was originally inspired by BIDS, so I'm very happy to see there's some interest here! A couple initial notes, and I'd love to set up a longer conversation as well.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments... Haven't reviewed in general.
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
Outdated
Show resolved
Hide resolved
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@mekline Thanks for the update. 😄 I am thinking that maybe members of the BIDS and psych-DS community who are interested could have a video meeting to maybe figure out how to best coordinate our efforts, no? |
Definitely - I"m guessing this github issue isn't the best channel to reach
all interested parties - should I write to bids-discussion, or is there
some better place to reach likely interested people?
…On Tue, Aug 18, 2020 at 5:23 AM Remi Gau ***@***.***> wrote:
Hi all, thanks for tagging me in. I would be very open to making PsychDS
work well for BIDS, or otherwise aligning as far as possible! PsychDS was
originally inspired by BIDS, so I'm very happy to see there's some interest
here!
@mekline <https://github.com/mekline> Thanks for the update. 😄
I am thinking that maybe members of the BIDS and psych-DS community who
are interested could have a video meeting to maybe figure out how to best
coordinate our efforts, no?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#573 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUA75JW2LDXHET4IF7OCA3SBJCBTANCNFSM4QAIJ7VA>
.
|
Yup I think that the bids-discussion is the best AFAICT and then we can spread the words in other channels if we set up a video call or something. :-) |
@effigies I believe that the number of files changed is now equal to 1. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Mostly formatting suggestions. Significant rewording suggestion for one field.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@Remi-Gau @poldrack @robertoostenveld @mekline is there another thread/doc open somewhere? |
There is no other public thread as far I know. Will open one on the BIDS google group now to keep things separated because this PR is starting to resemble to my kitchen after I try making bread. |
@CPernet Happy to help on participants information import. |
@CPernet @ChristophePhillips might be worth seeing if some of that can be integrated into bids-matlab |
Not sure what's left on that one. Let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am +1 for merging. The uri
link can be improved upon in the following PR related to #601
@hoechenberger fine with you? |
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
f8c42d0
to
04f0926
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience and persistence and for bringing this up in the first place @Remi-Gau :-)
Thanks also to the many reviewers!
Mentioned in #558
Another low hanging fruit of metadata to add to any json for anything that involves presenting stimuli to a participant.
One question: should something like this be included in for
beh
json files out of internal consistency?