[ENH] Describe arbitrary units in Common Principles #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Sep 14, 2020
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
sappelhoff
approved these changes
Sep 18, 2020
effigies
approved these changes
Sep 18, 2020
|
@tsalo thanks for the PR. Can you go one more step (two actually 😉 ) and check that this new BIDS definition is observed in BEP009 and BEP001? |
bids-maintenance
added a commit
that referenced
this pull request
Sep 27, 2020
|
@sappelhoff There's a call this week for BEP001 where I plan to bring this up. I will also comment on BEP009 directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #580. Although I considered adding something to Appendix 5 (Units), it didn't seem to fit well with the contents of the Appendix, so I've limited this change to a single list item in Common Principles#Units.
Changes proposed: