[FIX] arrays of 3D coordinates MUST supply numeric values in x, y, z order #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
requested review from
tsalo,
effigies,
hoechenberger and
robertoostenveld
hoechenberger
approved these changes
Oct 1, 2020
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
Outdated
Show resolved
Hide resolved
|
Thanks @hoechenberger I'll have to adjust table pipes in a new commit. I'll wait a bit though, because I'll also have to fix "e.g." -> "for example", see #626 |
sappelhoff
force-pushed
the
order
branch
2 times, most recently
from
a16be18
to
79eca7c
Compare
sappelhoff
commented
Oct 2, 2020
| @@ -59,12 +59,12 @@ also encourage users to provide additional meta information extracted from the | |||
| manufacturer specific data files in the sidecar JSON file. Other relevant files | |||
| MAY be included alongside the original EEG data in `/sourcedata`. | |||
|
|
|||
| Note the RecordingType, which depends on whether the data stream on disk | |||
There was a problem hiding this comment.
@Remi-Gau I just rebased my changes on top of your "e.g." -> "for example" changes and noticed the trailing blank lines whitespace. Just as a hint for you: It may be nice (for any project you are doing) to configure your editor to automatically remove trailing whitespace.
Or is there a particular reason for having that?
effigies
approved these changes
Oct 2, 2020
hoechenberger
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #613
In this PR I add a clarification for all JSON fields that accept an
object of arrayswhere the arrays are expected to contain 3D coordinates.this is the clarification:
While doing this PR I stumbled over a small oddity: In MRI
AnatomicalLandmarkCoordinatesare expected to be in voxel unitsWhereas in MEG and EEG, it says:
probably related to https://github.com/bids-standard/bids-examples/issues/190 ... this is not very well specified in BIDS currently and I lack the practical experience (use cases, broad overview of research practice) to improve the state of the art. cc @robertoostenveld with whom I have discussed about this in #520 (comment)