Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] add brief note that TSV example in the spec may currently use either tab or space characters #643

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

yarikoptic
Copy link
Collaborator

@yarikoptic yarikoptic commented Oct 8, 2020

Inspired by realization while discussing now merged #619

See individual commits description for more information. A satellite issue on harmonization of tsv examples will be filed shortly #644

Original example in .md looks like tab separated since its
rendition is ugly, but it is just that -- spaces were not
used, not tabs.

Just so it might come handy (may be there is a command for that)
to display spaces and tabs for content in clipboard you could use
smth like

	$> xsel -o | sed -e 's, ,·,g' -e 's,\t,⇰,g'
	onset·duration⇰response_time⇰correct⇰stop_trial⇰go_trial
	200⇰200⇰0⇰n/a⇰n/a⇰n/a%
More work needs to be done to make it all uniform and factually correct.
In "theory" markdown sources should use tabs.  HTML (and PDF) rendering should
provide nice rendition of those while layouting into a proper tabular presentation
and using some unicode characters to depict tab symbols.

For now -- note should suffice
@sappelhoff
Copy link
Member

I feel like this should be an issue outlining the problem --> if all agree that all TSV examples in the spec should be formatted using tabs, then we would want a follow up PR that fixes all examples.

@VisLab
Copy link
Member

VisLab commented Oct 25, 2020 via email

@yarikoptic
Copy link
Collaborator Author

I feel like this should be an issue outlining the problem --> if all agree that all TSV examples in the spec should be formatted using tabs, then we would want a follow up PR that fixes all examples.

some issue beyond he one I have referenced? (#644)

The tsv examples in the spec are only a few lines long and I think it would
be more effective to have a link to an actual real tsv file wth tabs
rather than expecting that people are going to cut and paste the toy examples.

Good idea, but again a more "global one" -- to allow spec to point to good examples (not only for .tsv files but whole datasets, other types of files etc) from external links. We already have references to various aspects, and have linkchecker validating their validity. If there is no issue yet, please start one?

I find it very difficult to understand what the various values
correspond to when the column values don't line up --- especially since
these values can have blanks in them.

yeap, I am with you on this one. in #644 I outlined a possible solution at the level of "renderer" of the spec from source (which imho should use tabs) into visual form (html or pdf). The problem now that there is no consistency. This PR at least tries to bring some consistency within the "common principles" description (where fields iirc do not align visually anyways but also simply incorrect by using spaces instead of tabs).

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some issue beyond he one I have referenced? (#644)

no that one is perfect - I just overlooked it, sorry :)

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@sappelhoff sappelhoff changed the title BF: Do use tabs in TSV example and add a note that document might use spaces [MISC] add brief note that TSV example in the spec may currently use either tab or space characters Oct 29, 2020
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me.

@sappelhoff sappelhoff merged commit 1c2d88d into bids-standard:master Nov 2, 2020
@sappelhoff
Copy link
Member

Thanks everyone.

@yarikoptic yarikoptic deleted the bf-tab-example branch April 30, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants