-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] add paragraph on MEG specific "markers" suffix in MEG spec #653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
Co-authored-by: Chris Markiewicz <effigies@gmail.com> Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Super late to the party, but why can we not name those marker files |
that would make sense to me, would be good to go that way. We'd then still have to document and deprecate the |
this is the same name as the raw file so it would likely collide naming-wise |
Oh, darn, I wasn't aware of this! Ok, in that case we cannot do this. Sorry about the confusion. |
it is a historical and inconsistent pattern that was introduced. here's a brief history from what I can recall: the original extension for Ricoh continuous data was the original extension for Ricoh marker file was |
bids-standard#653 (comment) Co-authored-by: Teon L Brooks <teon.brooks@gmail.com>
awesome, thanks for shedding some light on this @teonbrooks! |
Co-authored-by: Teon L Brooks <teon.brooks@gmail.com>
closes #638 --> the
*_markers
suffix was only defined in the appendix and occurred quite unexpectedly and randomly.*_markers
seems to only apply to KIT/Yokogawa/RicohIf we could turn back time we would probably solve the issue on "how to define KIT marker files" without adding a new suffix entirely for that issue.
I suggest this minor fix (this PR) to at least increase transparency of the "markers" suffix in the spec text.
For future enhancements it'd be cool if we could think of a way to somehow salvage the "markers" suffix in a backwards compatible way and put it to some use beyond KIT/Yokogawa/Ricoh. --> suggestions in that direction are very welcome.
The relevant part of the diff is this sentence (rest is typos, linebreaks, a link fix. and a historical perspective in the appendix):