-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Update all links to use HTTPS whenever possible. #676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Noticed a small thing that could be easily wrapped into this PR, but feel free to reject to keep this focused.
The linkchecker failed because of https://talairach.org/ [SSL: CERTIFICATE_VERIFY_FAILED]. My browser is fine but wget/curl complains too: shall I revert to HTTP for that one link? |
Looks like a badly configured server (doesn't bundle the intermediate cert; browsers will fetch it, CURL won't): https://www.ssllabs.com/ssltest/analyze.html?d=talairach.org&latest It's the same cert for https://brainmap.org, so possibly @angielaird would know who to contact about fixing their config? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple changes. Also, to satisfy the linter, you're going to need to align the table fences (|
) in tables where the number of characters in a row has changed.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
I pushed a commit fixing the table pipe errors. I also started using a different link style in the "licenses" appendix. All text and links themselves stayed the same, but the link is now embedded in the name of the license. Overhauling the licenses also made me aware of our definition of the "public domain" license, which is not congruent with the information wiki.creativecommons We say:
They say:
Somebody should take a look in a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM generally if all links continue to work. Thanks Guillaume.
mmh connection timeout on https://www.nitrc.org/projects/pediatricatlas ... remaining links seem okay. And the connection timeout happens for both https and http. Maybe we can wait for a bit and it'll solve itself. |
Thanks @gllmflndn |
Checked all HTTP links and updated them if they can be served as HTTPS.