Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Update all links to use HTTPS whenever possible. #676

Merged
merged 6 commits into from
Nov 26, 2020
Merged

[MISC] Update all links to use HTTPS whenever possible. #676

merged 6 commits into from
Nov 26, 2020

Conversation

gllmflndn
Copy link
Contributor

Checked all HTTP links and updated them if they can be served as HTTPS.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Noticed a small thing that could be easily wrapped into this PR, but feel free to reject to keep this focused.

src/02-common-principles.md Outdated Show resolved Hide resolved
@gllmflndn
Copy link
Contributor Author

The linkchecker failed because of https://talairach.org/ [SSL: CERTIFICATE_VERIFY_FAILED]. My browser is fine but wget/curl complains too: shall I revert to HTTP for that one link?

@effigies
Copy link
Collaborator

Looks like a badly configured server (doesn't bundle the intermediate cert; browsers will fetch it, CURL won't): https://www.ssllabs.com/ssltest/analyze.html?d=talairach.org&latest

It's the same cert for https://brainmap.org, so possibly @angielaird would know who to contact about fixing their config?

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes. Also, to satisfy the linter, you're going to need to align the table fences (|) in tables where the number of characters in a row has changed.

src/99-appendices/02-licenses.md Outdated Show resolved Hide resolved
gllmflndn and others added 2 commits November 19, 2020 17:05
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
gllmflndn and others added 2 commits November 20, 2020 19:35
@sappelhoff
Copy link
Member

I pushed a commit fixing the table pipe errors.

I also started using a different link style in the "licenses" appendix. All text and links themselves stayed the same, but the link is now embedded in the name of the license.

Overhauling the licenses also made me aware of our definition of the "public domain" license, which is not congruent with the information wiki.creativecommons

We say:

No license required for any purpose; the work is not subject to copyright in any jurisdiction.

They say:

Works that are in the public domain in one legal jurisdiction are not necessarily in the public domain worldwide.

Somebody should take a look in a separate issue.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally if all links continue to work. Thanks Guillaume.

@sappelhoff sappelhoff changed the title [FIX] Update all links to use HTTPS whenever possible. [MISC] Update all links to use HTTPS whenever possible. Nov 23, 2020
@sappelhoff
Copy link
Member

mmh connection timeout on https://www.nitrc.org/projects/pediatricatlas ... remaining links seem okay. And the connection timeout happens for both https and http.

Maybe we can wait for a bit and it'll solve itself.

@sappelhoff sappelhoff merged commit 727ee87 into bids-standard:master Nov 26, 2020
@sappelhoff
Copy link
Member

Thanks @gllmflndn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants