[MAINT] Update bep009 from master #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ids-standard#738) * Adding clarification. * Fix clarifications. * Fix link. * Apply suggestions from code review Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Add link back. * Update src/06-longitudinal-and-multi-site-studies.md * Apply suggestions from code review Co-authored-by: Taylor Salo <tsalo006@fiu.edu> * Update src/06-longitudinal-and-multi-site-studies.md Co-authored-by: Taylor Salo <tsalo006@fiu.edu> * Fix docs. * line breaks Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
…nels+electrodes do not have to match (bids-standard#734) * clarify that label of _space-<label> must be from appendix VIII related to https://github.com/bids-standard/bids-validator/issues/743 * clarify that channels and electrodes do not have to match closes bids-standard#667 * catch typo again * link channels+electrodes examples * clarify _where_ restricted keywords for space entity come from * fix typo L -> l (capitalization) Co-authored-by: Chris Markiewicz <effigies@gmail.com> * extend yml lint limit to 120 chard * use existing .yamllint.yml file Co-authored-by: Chris Markiewicz <effigies@gmail.com>
* update mkdocs install instructions * add hard and soft style guide rules to CONTRIBUTING * fix json string example formatting * fix typos, word wrapping, abbreviations * Apply suggestions from code review Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Update src/04-modality-specific-files/04-intracranial-electroencephalography.md Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Apply suggestions from code review Thanks for these Taylor Co-authored-by: Taylor Salo <tsalo006@fiu.edu> * Apply suggestions from code review Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * reformat string examples from merged ASL section * apply linter on raw spec files * pacify the linter gods Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
* bump nodejs in markdown check CI * explicitly point to .remarkrc from remark CI * bump npm package versions for remark * try global install * try exporting node path * back to using local install * ignore npm package.json package-lock.json, and node_modules * remove unnecessary words * fix list space indents * streamline remark flow in .circleci * cleanup code * indentations in yml * indentation once more * amend CONTRIBUTING to use npx * setup_remote_docker indentation? * persist to workspace indentation * indent fixes * remove prettier file and mention of it in contrib guide * add remark-lint-list-item-indent to requirements list needed to run locally * fix minor issues with remark * add note to be careful when using remark Co-authored-by: Remi Gau <remi_gau@hotmail.com> Co-authored-by: Remi Gau <remi_gau@hotmail.com>
[FIX] Mix up (typo) between ficiduals and landmarks in EEG spec
effigies
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
LGTM. Any notion why the linter is suddenly complaining about this?
src/04-modality-specific-files/09-positron-emission-tomography.md
95:5 warning Incorrect list-item indent: add 2 spaces list-item-indent remark-lint
96:5 warning Incorrect list-item indent: add 2 spaces list-item-indent remark-lint
97:5 warning Incorrect list-item indent: add 2 spaces list-item-indent remark-lint
98:5 warning Incorrect list-item indent: add 2 spaces list-item-indent remark-lint
|
I was wondering about that... I think there was a recent PR that changed the remark settings. Maybe that's it? I can fix the issues in this PR if that's alright. |
[INFRA] do not run remark on auto CHANGES
sappelhoff
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the merge conflict for one table.