[INFRA] add CI to find trailing whitespace #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
commented
Apr 19, 2021
There was a problem hiding this comment.
Okay, this also looks at binary files. It seems like the GitHub action I found it not very far in its development and may lack some features.
I'll return to this PR in the near future. If any of you have suggestions and/or comments meanwhile --> please let me know.
|
I'm a little surprised that the Markdown linter doesn't catch trailing whitespace. Is that not an option for that Action? |
|
Thanks @tsalo I did not think of that. It's a much better solution and it seems to work. Please review if you can find some time :-) |
sappelhoff
force-pushed
the
ci/whitespace
branch
from
e33b715
to
0fe2c7b
Compare
bids-maintenance
added a commit
that referenced
this pull request
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CI steps that alerts us about trailing whitespace.
With some users having their editors configured to automatically remove it and others not, we are in a situation where we continuously add and remove senseless trailing whitespace. That negatively affects the git diff and makes review harder.
This CI step should solve the problem by alerting us to not merge any changes with trailing whitespace.
Came up as part of #777