[INFRA] In PDF, color every other row in table in light gray fill

[sappelhoff]

closes #659

This took me way longer than it should have ... there are many challenges with our pdf generation code, but I think I fixed more than I destroyed. Some of the options we were passing previously were never actually passed, and I still need to figure out why.

Anyhow, this is a start:

• table rows have alternating colors ... BUT the setting that "start at row 1 and color every even one light gray" does not work fully --> no idea why, but it's not too bad visually. (an improvement over status quo, I think)
• several options that we were previously passing (including color of links) were somehow swallowed without any alarms raised --> this is now fixed, which also results in slightly changed formatting of code sections (improved, IMHO)
• we started to accidentally include non-spec MD files in the PDF version of the spec, such as the raw pre-github changelog, or the README of the schema sub-folder (intended for development docs, not spec content) --> this is now fixed.

From my side, this is ready to be merged - but a lot remains to be done in the future.

[KirstieJane]

(Just swinging by here because I bet this was a weirdly hard PR but I think it will be super useful! Thank you 🙏 )

[effigies]

Is it possible to improve the alignment of the gray fill with the text/borders?

Also, I think it would look a little nicer if the header row remained white. In fact, I feel like I would flip it exactly, since there's a line to distinguish the header from the first row, so both could be white.

[effigies]

Definitely an improvement in any case. Thanks!

[sappelhoff]

Also, I think it would look a little nicer if the header row remained white. In fact, I feel like I would flip it exactly, since there's a line to distinguish the header from the first row, so both could be white.

yes, something is fishy but I couldn't figure out the problem. See these two tables on page 99: They have different coloring although according to the setting, they shouldn't have.

Screenshot:

[Remi-Gau]

Also, I think it would look a little nicer if the header row remained white. In fact, I feel like I would flip it exactly, since there's a line to distinguish the header from the first row, so both could be white.

Am I wrong or the first rwo being gray is not consistent from one table to the next?

But as @effigies said, an improvement already so heppy to merge as is and improve later.

[Remi-Gau]

Good with me

[sappelhoff]

Am I wrong or the first rwo being gray is not consistent from one table to the next?

no, you are correct 😄 this is something I couldn't figure out, and that I gave up after about one hour of screaming: #794 (comment)

[Remi-Gau]

Am I wrong or the first rwo being gray is not consistent from one table to the next?

no, you are correct smile this is something I couldn't figure out, and that I gave up after about one hour of screaming: #794 (comment)

ONE HOUIR!? I admire your tenacity.