[MISC] Move section on sessions.tsv file: longitudinal files -> modality agnostic files #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
reviewed
May 25, 2021
sappelhoff
reviewed
Jun 3, 2021
effigies
reviewed
Jun 3, 2021
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Remi-Gau
commented
Jun 9, 2021
sappelhoff
changed the title
effigies
reviewed
Jul 29, 2021
Remi-Gau
added a commit
to Remi-Gau/bids-specification
that referenced
this pull request
Jul 29, 2021
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
approved these changes
Jul 30, 2021
|
Thanks @Remi-Gau |
sappelhoff
added a commit
that referenced
this pull request
Aug 31, 2021
* Initial work. * update code to render simple examples (list and simple dictionaries) * create a separate module for example creation * start applying to spec * remove dead code * apply to MRI page * fix tabulation on scans.tsv template * apply example macro to longitudinal page * apply to common principles * revert changes on scans.tsv templates addressed in #805 * remove extra line after listing directory content * only use python dictionaries for examples rendering * update examples common principles * update example longitudinal page * update examples MRI page * update examples MEG * update examples iEEG * update examples task * update physio example * update examples common data types derivatives * update examples imaging datatypes * change "participant-label" to "label" in derivatives templates * update examples meg file formats * update qmri examples * reduce width prefixes * add a flag to be able to not use "pipes" prefix * switch use_pipe flag to off when building pdf * create an examplecode module * add demo jupyter notebook for tree example * add doc in code * add doc to CONTRIBUTING * remove non macro examples * fix typos (comment padding and missing folders) * temporary commit * remove comment * fix import * fix markdown linting errors * Apply suggestions from code review Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Apply suggestions from code review Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * remove jupyter notebook output * revert changes to import in schema code init * revert change of import of main in macro module this style of import is required for the building of the pdf Co-authored-by: Taylor Salo <tsalo006@fiu.edu> Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #796
sessions.tsvto the modality agnostic page.For reviewers
These edits are simple copy paste and might affect the "flow" of the text.
Especially for the common principle page, I tried to add it in the place that made most sense ("filename structure") but some of the information added there relates to folder structure, so this is not ideal.
Before moving on further on this I would be curious to hear your thoughts.