Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] make table headers bold #815

Merged
merged 6 commits into from
Jun 1, 2021

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jun 1, 2021

Applies #808 to the master branch.

I cherry picked the relevant commit only and opened a PR with those.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! So you want to merge #815 into master, and #808 into the schema branch?

@sappelhoff sappelhoff changed the title [STY] boldify table headers (on master) [MISC] make table headers bold Jun 1, 2021
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small comment.

Comment on lines +23 to +30
| 🧑‍🏫 | Mentoring new contributors |
| 🔌 | Plugin/utility libraries |
| 📆 | Project management |
| 👀 | Reviewed Pull Requests |
| 🔧 | Tools |
| 🌍 | Translation |
| ⚠️ | Tests |
| ✅ | Tutorials |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some weirdness with three of these.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix those now

FYI: using remark to fix stuff in some files creates so many false positives I had to do things the good old way...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@effigies @Remi-Gau this rings a bell --> it might be that these are odd due to the "length" of the emojis. I remember that was screwing something up.

As long as it renders nicely, I suggest to leave this untouched.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Sorry for the noise.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh phewy
because running remark on this was just reverting the manual change that the CI was giving a green check for... 🤷

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert that last one...

@sappelhoff sappelhoff merged commit e0ad5cd into bids-standard:master Jun 1, 2021
@sappelhoff
Copy link
Member

Thanks @Remi-Gau!

@Remi-Gau Remi-Gau deleted the bold_table-header branch June 1, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants