Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Add basic documentation on how to use metadata table macros #840

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

Remi-Gau
Copy link
Collaborator

fixes #838

This is not perfect but provides some guidance on how to use the metadata table macros.

@Remi-Gau Remi-Gau requested a review from tsalo July 30, 2021 16:34
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some wording suggestions, overall LGTM

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@sappelhoff sappelhoff changed the title [DOC] basic explaination on how to use metadata table macros [INFRA] Add basic documentation on how to use metadata table macros Aug 2, 2021
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor typo. Other than that it looks great!

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sappelhoff sappelhoff merged commit 3af64fd into bids-standard:master Aug 9, 2021
@sappelhoff
Copy link
Member

Thanks @Remi-Gau

@Remi-Gau Remi-Gau deleted the doc_macros branch August 21, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation to explain how to "customize" the macro calls to create metadata tables
3 participants