-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Optionally support echo entity for VFA suffix #989
Conversation
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
=========================================
Coverage ? 36.16%
=========================================
Files ? 8
Lines ? 788
Branches ? 0
=========================================
Hits ? 285
Misses ? 503
Partials ? 0 Continue to review full report at Codecov.
|
Added the closes line to the PR text. |
51eac3a
to
b8506ba
Compare
b8506ba
to
31d72b3
Compare
@effigies added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema change looks good. My only question is, are there any changes/updates that should be made to the qMRI appendix page (https://bids-specification.readthedocs.io/en/latest/99-appendices/11-qmri.html)? For example, there's a table that links "file collection" suffixes with qMRI suffixes, and VFA is listed there. Should a new row be added with the appropriate applications for VFA acquisitions with multiple echoes?
@tsalo I don't think this would be required at this point, and if it would be in the future, I presume the data would no longer be
|
@effigies this is pertaining to: #977 (comment)
@sappelhoff The PR text told me to ping you for questions.
Should I add a
Closes:
line to the commit, will this automatically close the issue once merged?Closes #977.