-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Introduce the atlas entity for derivatives data #997
[ENH] Introduce the atlas entity for derivatives data #997
Conversation
Codecov Report
@@ Coverage Diff @@
## master #997 +/- ##
==========================================
+ Coverage 34.05% 35.13% +1.07%
==========================================
Files 8 8
Lines 834 834
==========================================
+ Hits 284 293 +9
+ Misses 550 541 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me too
These filename entities, which appear in the corresponding text, were added in bids-standard#997, but the schema was only updated for the JSON sidecar entities.
Dear BIDS community,
Following an old discussion initiated in PR #265, I am opening this PR which introduces the entity
atlas-<label>
for derivatives data, which seems to be necessary to differentiate a different parcellation atlas used for similar type of derivatives data such as segmentation and connectome files (See discussion around it in the BEP017: Generic BIDS connectivity data schema).Please let me know what you think and any suggestions for improvements are welcome!
Best,
Sebastien