Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Introduce the atlas entity for derivatives data #997

Merged
merged 6 commits into from
Feb 19, 2022

Conversation

sebastientourbier
Copy link
Collaborator

Dear BIDS community,

Following an old discussion initiated in PR #265, I am opening this PR which introduces the entity atlas-<label> for derivatives data, which seems to be necessary to differentiate a different parcellation atlas used for similar type of derivatives data such as segmentation and connectome files (See discussion around it in the BEP017: Generic BIDS connectivity data schema).

Please let me know what you think and any suggestions for improvements are welcome!

Best,
Sebastien

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #997 (2ef9207) into master (2507964) will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
+ Coverage   34.05%   35.13%   +1.07%     
==========================================
  Files           8        8              
  Lines         834      834              
==========================================
+ Hits          284      293       +9     
+ Misses        550      541       -9     
Impacted Files Coverage Δ
tools/schemacode/schemacode/_version.py 38.90% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b9f48...2ef9207. Read the comment docs.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me too

@effigies effigies merged commit 6043989 into bids-standard:master Feb 19, 2022
mguaypaq added a commit to mguaypaq/bids-specification that referenced this pull request Jul 31, 2023
These filename entities, which appear in the corresponding text,
were added in bids-standard#997, but the schema was only updated for the JSON
sidecar entities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants