-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Add qMRI fmap filename rules and reorganize fmap patterns #1183
Conversation
The part I'm stuck on is how the |
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
+ Coverage 79.05% 79.07% +0.01%
==========================================
Files 78 78
Lines 2617 2619 +2
Branches 598 598
==========================================
+ Hits 2069 2071 +2
Misses 407 407
Partials 141 141
Continue to review full report at Codecov.
|
|
Thanks! It sounds like replicating the full set of patterns, minus jsons, was the way to go then. |
What if we just say |
I know so little about JavaScript that I'm not sure how to do that, but the general idea sounds solid to me. |
Will make a code recommendation, and we can see if it works... |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should fix the linting errors...
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
…-standard#1183) * Model field map patterns on schema. * Add nii versions. * Update bids-validator/utils/type.js Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Apply suggestions from code review Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Update bids-validator/bids_validator/rules/file_level_rules.json * Update bids-validator/utils/type.js Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Stems from bids-standard/bids-examples#245 (comment).
Changes proposed:
dir
entity required for_epi
and_m0scan
field maps.