Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Continue Windows builds even if chocolatey complains #1766

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Aug 4, 2023

Looks like nobody takes particular responsibility for problems with the git.install package, but it can fail because the same version already exists on the system. (See chocolatey/choco#1691)

Fixes #1765. I hope.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6fc6d15) 83.40% compared to head (7de9557) 83.40%.

❗ Current head 7de9557 differs from pull request most recent head 8740103. Consider uploading reports for the commit 8740103 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1766   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files          92       92           
  Lines        3893     3893           
  Branches     1270     1270           
=======================================
  Hits         3247     3247           
  Misses        548      548           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator Author

effigies commented Aug 4, 2023

Seems to have worked.

@effigies effigies merged commit 0854a36 into bids-standard:master Aug 4, 2023
21 of 24 checks passed
@effigies effigies deleted the ci/fix_windows branch August 4, 2023 17:43
@sappelhoff
Copy link
Member

Thanks @effigies I initially also thought this was just a blip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure: Windows git-annex installation
2 participants