Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for expected error types, rethrow unknown #2157

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

effigies
Copy link
Collaborator

Partially addresses #2130. @rwblair is working on fixing the real error.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 87.51%. Comparing base (cfedf64) to head (ebd86bf).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
bids-validator/src/schema/context.ts 33.33% 12 Missing ⚠️
bids-validator/src/validators/bids.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2157      +/-   ##
==========================================
+ Coverage   85.73%   87.51%   +1.78%     
==========================================
  Files          91      133      +42     
  Lines        3785     7050    +3265     
  Branches     1220     1669     +449     
==========================================
+ Hits         3245     6170    +2925     
- Misses        454      785     +331     
- Partials       86       95       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator Author

@rwblair This should go in before a release.

@rwblair rwblair merged commit 3bd537c into bids-standard:master Oct 11, 2024
18 of 19 checks passed
@effigies effigies deleted the fix/missing-error-key branch October 11, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants