Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add mrs and micr to folders and files pages #514

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[ENH] add mrs and micr to folders and files pages #514

merged 2 commits into from
Sep 27, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Sep 27, 2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to use a macro that renders this page automatically based on the schema rather that having this horror of HTML we have to manually update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please, otherwise we always would be out of date and (manual) duplication is evil -- error prone etc thus begging for removal of such a page altogether (after all -- this is just duplication of information from the spec, which also changes with EVERY version release).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. This page comes from the old Starterkit which is jupyter book based and does not have the type of macros that mkdocs does so I had not bothered to automate that.
But given that I have a script to do it, turning it into a macro should be fairly easy.

@Remi-Gau Remi-Gau marked this pull request as ready for review September 27, 2024 11:17
@Remi-Gau Remi-Gau merged commit 52a8f00 into main Sep 27, 2024
4 of 5 checks passed
@Remi-Gau Remi-Gau deleted the fix/files branch September 27, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants