-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
centralize converters #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes required.
The most annoying would sorting the covnerters alphabetically. I think we can maybe add that as some sort of mini validation in another PR: so maybe tackle the easy things first and ping me when you are done with those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreeing with most of Remi's comments, but less particular about their execution happening now. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, just spotted some changes that should be made on a tool. Damion can you please incorporate?
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
…into 442-centralize-converters
- tools/converters/meeg.md | ||
- tools/converters/physio.md | ||
- tools/converters/others.md | ||
- tools/converters.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This the main change.
The rest is "cosmetic".
seems that our markdown linting does not raise warnings as error will fix in a separate PR |
This PR will (eventually) close #442
Would like feedback on this draft, please.
Also, unsure why the subfile/subpages (eg converters/eeg.md) left behind "unknown" entries in the table of contents when deleted. How do I clear those table of contents entries. Ideas? @Remi-Gau @bendhouseart ?