-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Let CircleCI render PRs to improve PR review #85
Conversation
@poldrack this relates to what we were shortly discussion yesterday regarding building the website for pull requests. Just that you are aware that @sappelhoff already initiated action on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main issue is with finding the CSS:
bids-website/_layouts/default.html
Line 68 in fa20bfe
<link rel="stylesheet" href="{{ '/assets/css/style.css' | relative_url }}"> |
I think we need to drop the initial /
. It may cause some issues if we have HTML files in deeper directories, but we can worry about that later.
Edit: Actually, this is probably an issue for all cases where "/assets
appears in the template.
.github/workflows/main.yml
Outdated
with: | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
artifact-path: 0/html/index.html | ||
circleci-jobs: build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be working. Do we just want to add:
.circleci/artifact_path
:
0/html/index.html
@effigies this seems to work now. Thanks to your changes (with minor correction) |
closes #81
Issues
current artifacts: https://circleci.com/gh/bids-standard/bids-website/6#artifacts/containers/0
see for example the index.html: https://6-38337026-gh.circle-artifacts.com/0/home/circleci/project/_site/index.html