[FIX] use absolute path and not resolve to avoid getting into git annex #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Works :-))))))) |
julia-pfarr
approved these changes
Nov 30, 2023
|
but the tests fail |
oh that's because the OSF data changed so we need to merge #40 first |
* Change output filename & ScreenResolution return values - output filenames: according to issue bids-standard#24: output file has now the prefix of the edf file. If edf file already contains "_eyetrack" suffix, it is not written again. - ScreenResolution threw an error because it expected integers but it returned strings --> changed to integers * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * include code for extracting eyetrack.tsv samples table * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update ignore * lint * fix some tests * adapt test * run on python 3.12 * only work with full asc files * refactor and fix * add xfail * changed functions of CalibrationCount and CalibrationPosition to work for data of both eyes * changed functions for Average and MaximalCalibrationError to split array in arrays of two when both eyes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * modify function for Average and Max Calibration error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add tests for 2eyes dataset * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add warning when input files are missing * update tests to new input files * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43