-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix testing suite #4
Conversation
I'm getting the following error: Run python -m pytest --pyargs bids/reports --cov=bids/reports
[2](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:2)
python -m pytest --pyargs bids/reports --cov=bids/reports
[3](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:3)
shell: /usr/bin/bash {0}
[4](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:4)
env:
[5](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:5)
pythonLocation: /opt/hostedtoolcache/Python/3.7.12/x[6](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:6)4
6
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.7.12/x64/lib
[8](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:8)
ImportError while loading conftest '/home/runner/work/pybids-reports/pybids-reports/bids/reports/tests/conftest.py'.
[9](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:9)
bids/reports/__init__.py:2: in <module>
[10](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:10)
from . import _version, parameters, parsing, report
[11](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:11)
bids/reports/parameters.py:10: in <module>
[12](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:12)
from bids.reports.utils import list_to_str, num_to_str, remove_duplicates
[13](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:13)
E ModuleNotFoundError: No module named 'bids.reports'
[14](https://github.com/bids-standard/pybids-reports/runs/5169084359?check_suite_focus=true#step:6:14)
Error: Process completed with exit code 4. I installed my fork's |
@effigies do you have any idea why the parent package wouldn't retain the namespace package when both are installed? |
So what I did above makes things work in full installations, but not in editable mode ( We could move it to |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage ? 74.49%
=======================================
Files ? 11
Lines ? 945
Branches ? 0
=======================================
Hits ? 704
Misses ? 241
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closes #2.
Changes proposed in this pull request:
To do