Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Update mustache templates #67

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 5, 2024

No description provided.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Feb 5, 2024

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Feb 5, 2024

should probably check out for today

@tsalo can I let start looking how we want to deal with institution and scanner info?

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1f4aeea) 86.91% compared to head (1e15c27) 89.97%.
Report is 2 commits behind head on main.

Files Patch % Lines
bids/ext/reports/cli.py 86.36% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   86.91%   89.97%   +3.05%     
==========================================
  Files          14       15       +1     
  Lines         688      708      +20     
==========================================
+ Hits          598      637      +39     
+ Misses         90       71      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member

tsalo commented Feb 5, 2024

I'm happy to take a crack at it in a separate PR, but I'd learn toward putting it in the general acquisition description:

# description_list = [general_acquisition_info(data_files[0][0].get_metadata())]

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Feb 5, 2024

am OK with that

I suspect we can ignore the case where MRI data is acquired on different scanners but stored in the same session : technically BIDS valid but hopefully rare enough

@Remi-Gau Remi-Gau merged commit cc5afbd into bids-standard:main Feb 6, 2024
19 checks passed
@Remi-Gau Remi-Gau deleted the templates branch February 6, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants