Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update numpy dependency requirement for Python <3.7 #686

Closed
wants to merge 2 commits into from

Conversation

oesteban
Copy link
Collaborator

@oesteban oesteban commented Dec 6, 2020

The recently released numpy 1.20 drops Python 3.6

@effigies
Copy link
Collaborator

effigies commented Dec 6, 2020

I was just looking into this for nibabel. It's weird that 1.20.0rc1 is getting installed without --pre flags, and also python_requires is not being respected by pip. This seems like it might be resolved by blacklisting pip versions.

@effigies
Copy link
Collaborator

effigies commented Dec 6, 2020

Ah, no, apparently it's setuptools not being as smart as pip:

Looks like python setup.py install is just no longer recommended.

@oesteban
Copy link
Collaborator Author

oesteban commented Dec 6, 2020

Looks like python setup.py install is just no longer recommended.

Yup, that's what I understood from https://snarky.ca/what-the-heck-is-pyproject-toml/

@effigies
Copy link
Collaborator

effigies commented Dec 6, 2020

So should we work to support the setup.py install use case for downstream tools? (That's what I'm interpreting this PR as doing.)

@oesteban
Copy link
Collaborator Author

oesteban commented Dec 6, 2020

I think so, for a smooth transition to PEP517/8. Also to allow some more time for PEP517 builders to settle in.

@effigies
Copy link
Collaborator

effigies commented Dec 6, 2020

But the fix is just to use pip install and let it do dependency resolution.

@effigies effigies closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants