Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that orientation is still absent after reloading Exif #2

Merged

Conversation

radarhere
Copy link

Suggestions for python-pillow#6463

  1. I've noticed that the tests in the PR pass even without the change to ImageOps. You've done the right thing, the problem is that Once exif data is parsed, do not reload unless it changes python-pillow/Pillow#6335 means that the "XML:com.adobe.xmp" data isn't checked after exif_transpose is run. So I've updated the tests to run _reload_exif(), so that it is checked.
  2. I created a test image using one of our existing test images and exiftool -orientation#=3 -exif= color_snakes.png. By having an orientation of 3, it allowed the test code to be a bit simpler, since the orientations match.

@bigcat88 bigcat88 merged commit 5d8dacf into bigcat88:xmp-tags-orientation Jul 29, 2022
@radarhere radarhere deleted the xmp-tags-orientation branch July 31, 2022 02:35
bigcat88 pushed a commit that referenced this pull request Oct 27, 2022
bigcat88 pushed a commit that referenced this pull request Jan 10, 2023
Use jpeg_write_marker to write comment
bigcat88 pushed a commit that referenced this pull request Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants