feat(BUN-2087): refactoring hooks eslint rule (#947)

* feat(BUN-2087): refactoring eslint rule * feat(BUN-2087): nit
bigcommerce · Feb 28, 2024 · 612f8b3 · 612f8b3
1 parent 6129f7e
commit 612f8b3
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 10 deletions.
diff --git a/apps/storefront/.eslintrc.json b/apps/storefront/.eslintrc.json
@@ -6,7 +6,6 @@
         "src/pages/**/*.{ts,tsx}",
         "src/utils/**/*.{ts,tsx}",
         "src/components/**/*.{ts,tsx}",
-        "src/hooks/dom/*.ts",
         "src/shared/**/**.*ts"
       ],
       "rules": {
@@ -151,7 +150,12 @@
       "rules": { "react/jsx-wrap-multilines": 0 }
     },
     {
-      "files": ["src/components/**/*.tsx", "src/pages/**/*.{ts,tsx}"],
+      "files": [
+        "src/components/**/*.tsx",
+        "src/pages/**/*.{ts,tsx}",
+        "src/hooks/**/*.ts",
+        "src/hooks/*.ts"
+      ],
       "rules": { "import/extensions": 0 }
     },
     {

diff --git a/apps/storefront/src/hooks/dom/useCartToQuote.ts b/apps/storefront/src/hooks/dom/useCartToQuote.ts
@@ -169,8 +169,9 @@ const useCartToQuote = ({
     }
 
     if (document.querySelectorAll('.b2b-cart-to-quote')?.length) {
-      const cartToQuoteBtn = document.querySelectorAll('.b2b-cart-to-quote')
-      cartToQuoteBtn.forEach((cartToQuoteBtn: CustomFieldItems) => {
+      const cartToQuoteBtns = document.querySelectorAll('.b2b-cart-to-quote')
+      cartToQuoteBtns.forEach((button: CustomFieldItems) => {
+        const cartToQuoteBtn = button
         cartToQuoteBtn.innerHTML = cartToQuoteBtnLabel
         cartToQuoteBtn.setAttribute('style', customCss)
         cartToQuoteBtn.style.backgroundColor = color

diff --git a/apps/storefront/src/hooks/dom/useDomVariation.ts b/apps/storefront/src/hooks/dom/useDomVariation.ts
@@ -27,7 +27,8 @@ const useDomVariation = (dom: string, quoteCallBbck?: () => void) => {
     if (doms.length) {
       doms.forEach((dom: CustomFieldItems) => {
         if (!dom?.ready) {
-          dom.ready = true
+          const d = dom
+          d.ready = true
           changeQuickview()
         }
       })

diff --git a/apps/storefront/src/hooks/dom/useHideGoogleCustomerReviews.ts b/apps/storefront/src/hooks/dom/useHideGoogleCustomerReviews.ts
@@ -21,8 +21,8 @@ const useHideGoogleCustomerReviews = (
     const newVisibilityStyle = isOpen ? 'none' : 'inline-block'
 
     googleCustomerReviewsDoms.forEach((dom) => {
-      if (dom?.parentElement)
-        dom.parentElement.style.display = newVisibilityStyle
+      const d = dom
+      if (d?.parentElement) d.parentElement.style.display = newVisibilityStyle
     })
   }, [isOpen])
 }

diff --git a/apps/storefront/src/hooks/dom/useMyQuote.ts b/apps/storefront/src/hooks/dom/useMyQuote.ts
@@ -142,7 +142,8 @@ const useMyQuote = ({
 
   const addBtnStyle = () => {
     const myQuoteBtn = document.querySelectorAll('.b2b-add-to-quote')
-    myQuoteBtn.forEach((myQuote: CustomFieldItems) => {
+    myQuoteBtn.forEach((quote: CustomFieldItems) => {
+      const myQuote = quote
       myQuote.innerHTML = myQuoteBtnLabel
       myQuote.setAttribute(
         'style',

diff --git a/apps/storefront/src/hooks/dom/useOpenPDP.ts b/apps/storefront/src/hooks/dom/useOpenPDP.ts
@@ -163,8 +163,9 @@ export const useOpenPDP = ({ setOpenPage, role }: MutationObserverProps) => {
           (shoppingListBtn as CustomFieldItems)[key]
       )
       if (!isAddStyle) {
-        const myShoppingListBtn = document.querySelectorAll('.b2b-add-to-list')
-        myShoppingListBtn.forEach((myShoppingListBtn: CustomFieldItems) => {
+        const myShoppingListBtns = document.querySelectorAll('.b2b-add-to-list')
+        myShoppingListBtns.forEach((button: CustomFieldItems) => {
+          const myShoppingListBtn = button
           myShoppingListBtn.innerHTML = myShoppingListBtnLabel
           myShoppingListBtn.setAttribute('style', customCss)
           myShoppingListBtn.style.backgroundColor = color