fix: eslint

- enable eslint typescript rules instead of default - remove namespace as it is not recommended anymore
bigcommerce · Jul 22, 2022 · 8018f84 · 8018f84
1 parent f2459b6
commit 8018f84
Show file tree

Hide file tree

Showing 12 changed files with 25 additions and 25 deletions.
diff --git a/apps/storefront/package.json b/apps/storefront/package.json
@@ -12,6 +12,7 @@
   },
   "dependencies": {
     "@b3/lang": "*",
+    "@b3/global-b3": "*",
     "@emotion/cache": "^11.9.3",
     "@emotion/react": "^11.9.3",
     "@emotion/styled": "^11.9.3",

diff --git a/apps/storefront/src/components/form/B3Picker.tsx b/apps/storefront/src/components/form/B3Picker.tsx
@@ -22,6 +22,7 @@ import Form from './ui'
 
 export const B3Picker = ({
   control,
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   errors,
   ...rest
 } : Form.B3UIProps) => {
@@ -63,7 +64,9 @@ export const B3Picker = ({
                 {...fieldsProps}
                 render={({
                   field: {
-                    ref, ...rest
+                    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+                    ref,
+                    ...rest
                   },
                 }) => (
                   <DesktopDatePicker

diff --git a/apps/storefront/src/pages/registered/Registered.tsx b/apps/storefront/src/pages/registered/Registered.tsx
@@ -153,6 +153,7 @@ export default function Registered(props: RegisteredProps) {
         }
         setLogo(registerLogo)
       } catch (e) {
+        // eslint-disable-next-line no-console
         console.log(e)
       }
     }

diff --git a/apps/storefront/src/pages/registered/RegisteredAccount.tsx b/apps/storefront/src/pages/registered/RegisteredAccount.tsx
@@ -155,6 +155,7 @@ export default function RegisteredAccount(props: RegisteredAccountProps) {
           },
         })
       }).catch((err: any) => {
+        // eslint-disable-next-line no-console
         console.log(err)
         dispatch({
           type: 'loading',

diff --git a/apps/storefront/src/pages/registered/RegisteredBCToB2B.tsx b/apps/storefront/src/pages/registered/RegisteredBCToB2B.tsx
@@ -141,7 +141,8 @@ export default function RegisteredBCToB2B() {
         }
         setLogo(registerLogo)
       } catch (e) {
-        console.log(e)
+        // eslint-disable-next-line no-console
+        console.error(e)
       }
     }
 
@@ -219,6 +220,7 @@ export default function RegisteredBCToB2B() {
 
   const handleNext = (event: MouseEvent) => {
     handleSubmit(async (data: CustomFieldItems) => {
+      // eslint-disable-next-line no-console
       console.log(data, 'data')
     })(event)
   }

diff --git a/apps/storefront/src/shared/service/request/base.ts b/apps/storefront/src/shared/service/request/base.ts
@@ -1,5 +1,6 @@
 import globalB3 from '@b3/global-b3'
 
+// eslint-disable-next-line no-console
 console.log(globalB3, 'globalB3')
 
 const B2B_BASIC_URL = (window as any)?.b3?.setting?.B2B_URL || import.meta.env.VITE_B2B_BASIC_URL

diff --git a/packages/eslint-config-b3/index.js b/packages/eslint-config-b3/index.js
@@ -1,5 +1,6 @@
 module.exports = {
   extends: ['react', 'airbnb'],
+  plugins: ['@typescript-eslint'],
   parser: '@typescript-eslint/parser',
   rules: {
     'no-shadow': 0,
@@ -45,7 +46,8 @@ module.exports = {
         ignore: ['antd-mobile'],
       },
     ],
-    'no-unused-vars': 1,
+    'no-unused-vars': 0,
+    '@typescript-eslint/no-unused-vars': 1,
     'consistent-return': 0,
     'react/jsx-no-useless-fragment': 0,
     'implicit-arrow-linebreak': 0,

diff --git a/packages/eslint-config-b3/package.json b/packages/eslint-config-b3/package.json
@@ -2,23 +2,19 @@
   "name": "eslint-config-b3",
   "version": "0.0.0",
   "main": "index.js",
-  "dependencies": {
-    "eslint-config-react": "^1.1.7",
-    "eslint-plugin-react": "^7.30.1"
-  },
   "publishConfig": {
     "access": "public"
   },
   "devDependencies": {
+    "eslint-config-react": "^1.1.7",
+    "eslint-plugin-react": "^7.30.1",
     "@typescript-eslint/eslint-plugin": "^5.30.4",
     "@typescript-eslint/parser": "^5.30.4",
     "eslint": "^8.2.0",
     "eslint-config-airbnb": "^19.0.4",
     "eslint-plugin-import": "^2.25.3",
     "eslint-plugin-jsx-a11y": "^6.5.1",
-    "eslint-plugin-react": "^7.28.0",
     "eslint-plugin-react-hooks": "^4.3.0",
     "typescript": "^4.6.3"
   }
 }
-
diff --git a/packages/lang/context/LangContext.tsx b/packages/lang/context/LangContext.tsx
@@ -8,7 +8,9 @@ import {
   Reducer,
 } from 'react'
 
-import B3Utils from '@b3/utils'
+import {
+  LangUtils,
+} from '@b3/utils'
 
 interface LangContextState {
   lang: string,
@@ -20,7 +22,7 @@ interface LangContextAction {
 }
 
 const initState: LangContextState = {
-  lang: B3Utils.Lang.getBrowserLanguage(),
+  lang: LangUtils.getBrowserLanguage(),
 }
 
 export const LangContext: Context<{

diff --git a/packages/lang/useB3Lang.ts b/packages/lang/useB3Lang.ts
@@ -3,7 +3,7 @@ import {
 } from 'react-intl'
 
 export interface B3Lang {
-  (id: string, options?: {}): string
+  (id: string, options?: Record<string, never>): string
 }
 
 export const useB3Lang = () => {

diff --git a/packages/utils/Lang/index.ts b/packages/utils/Lang/index.ts
@@ -1,6 +1,6 @@
-export namespace Lang {
-  export const getBrowserLanguage = () => {
+export const Lang = {
+  getBrowserLanguage: () => {
     const lang = navigator.language
     return lang.substring(0, 2)
-  }
+  },
 }
diff --git a/packages/utils/index.ts b/packages/utils/index.ts
@@ -1,12 +1,3 @@
-// FIXME: no-unused-vars, disabled for export import X = vars
-/* eslint-disable no-unused-vars */
-
-import {
+export {
   Lang as LangUtils,
 } from './Lang'
-
-namespace B3Utils {
-  export import Lang = LangUtils
-}
-
-export default B3Utils