feat(component): add test to check if onRowDrop is called

bigcommerce · Jan 12, 2021 · f04ffcf · f04ffcf
1 parent 2a85714
commit f04ffcf
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 394 deletions.
diff --git a/packages/big-design/src/components/Table/Table.tsx b/packages/big-design/src/components/Table/Table.tsx
@@ -142,7 +142,7 @@ const InternalTable = <T extends TableItem>(props: TableProps<T>): React.ReactEl
   );
 
   const renderDroppableItems = () => (
-    <Droppable droppableId="bd-droppable">
+    <Droppable droppableId={`${uniqueTableId}-bd-droppable`}>
       {(provided) => (
         <Body withFirstRowBorder={headerless} ref={provided.innerRef} {...provided.droppableProps}>
           {items.map((item: T, index) => {
@@ -205,13 +205,6 @@ const InternalTable = <T extends TableItem>(props: TableProps<T>): React.ReactEl
     return null;
   };
 
-  const renderWithDragDropContext = () => (
-    <DragDropContext onDragEnd={onDragEnd}>
-      {renderHeaders()}
-      {renderItems()}
-    </DragDropContext>
-  );
-
   return (
     <>
       {shouldRenderActions() && (
@@ -229,7 +222,10 @@ const InternalTable = <T extends TableItem>(props: TableProps<T>): React.ReactEl
       )}
       <StyledTable {...rest} id={tableIdRef.current}>
         {onRowDrop ? (
-          renderWithDragDropContext()
+          <DragDropContext onDragEnd={onDragEnd}>
+            {renderHeaders()}
+            {renderItems()}
+          </DragDropContext>
         ) : (
           <>
             {renderHeaders()}