feat(component): Add drag and drop support to table component #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On exploring further realised that Particularly not happy with this approach, and would rather support the native type. But in that case onDragEnd interface becomes a bit tricky for end consumer in my opinion. Happy to hear thoughts on this? |
animesh1987
force-pushed
the
drag-and-drop
branch
from
c2c9ea9
to
e68591a
Compare
animesh1987
force-pushed
the
drag-and-drop
branch
from
d07f772
to
155abb9
Compare
animesh1987
force-pushed
the
drag-and-drop
branch
from
b532be6
to
2a85714
Compare
|
FYI @bigcommerce/artemis-dt |
deini
reviewed
Jan 7, 2021
animesh1987
force-pushed
the
drag-and-drop
branch
from
4de8d11
to
f04ffcf
Compare
animesh1987
force-pushed
the
drag-and-drop
branch
from
f04ffcf
to
807fff5
Compare
animesh1987
force-pushed
the
drag-and-drop
branch
from
807fff5
to
9dbe143
Compare
deini
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add drag and drop support to
Tablecomponent.Why
Feature request for Drag and Drop
ping @bigcommerce/frontend @deini @chanceaclark