feat(docs): spacing documentation #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deini
reviewed
Aug 9, 2019
| @@ -8,8 +8,8 @@ export const IconPropTable: React.FC = () => ( | |||
| <PropTable.Prop name="color" types={<Link href="/colors">Color</Link>}> | |||
| Sets the icon color given a color name from our <Link href="/colors">palette</Link>. | |||
| </PropTable.Prop> | |||
| <PropTable.Prop name="size" types={[<Link href="/utilities/spacing">Spacing</Link>, 'number']}> | |||
| Determines the size of the icon. Accepts a <Link href="/utilities/spacing">Spacing</Link> value or a number of px. | |||
| <PropTable.Prop name="size" types={[<Link href="/spacing">Spacing</Link>, 'number']}> | |||
There was a problem hiding this comment.
Don't you think spacing should be under utilities? /utilities/spacing
There was a problem hiding this comment.
We want to mimic design.bigcommerce.com and they put it under foundation, which makes more sense to me than utility, in any case. It's really the foundation of most of the components.
Co-Authored-By: Daniel Almaguer <danielalmaguer@gmail.com>
chanceaclark
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spacing Docs