Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add figma UI kit and sample app to resources section #206

Merged
merged 2 commits into from
Sep 30, 2019

Conversation

amckemie
Copy link
Contributor

What
Added links in Helpful Resources section for Figma UI Kit and sample app.

Why
https://jira.bigcommerce.com/browse/CHP-6053

To provide developers and designers with more resources to help them in building apps with BigDesign

@amckemie amckemie requested a review from a team September 30, 2019 17:06
@@ -48,6 +48,19 @@ export default () => {
Beta Community Group
</Link>
</List.Item>
<List.Item>
<Link
href="https://www.figma.com/file/jTVuUkiZ1j3rux8WHG4IKK/BigDesign-UI-Kit?node-id=0%3A1/duplicate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be a better idea to change url to https://www.figma.com/file/jTVuUkiZ1j3rux8WHG4IKK/BigDesign-UI-Kit. In fact there's no need to include the title, but I'm not sure if it would still redirect to the file if the title were to change (but probably would).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to remove that, as you were correct.

@amckemie amckemie merged commit bb07411 into bigcommerce:master Sep 30, 2019
@amckemie amckemie deleted the add-resource-links branch September 30, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants