fix #100 bug when response is a string #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will add couple more things hold on before merging. |
gregory
force-pushed
the
fix_issue_100
branch
2 times, most recently
from
23e693b to
b6cae10
Compare
| error_hash = env.body.empty? ? {} : JSON.parse(env.body, symbolize_names: true) | ||
| response_headers = {} | ||
| unless env.body.empty? | ||
| begin |
There was a problem hiding this comment.
Do you mean to say response_headers = begin... ?
We should rescue the JSON parsing fix rubocop
|
👍 |
mattolson
added a commit
that referenced
this pull request
Apr 29, 2015
fix #100 bug when response is a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: We should rescue the JSON parsing
cc @mattolson @pedelman