Add gift certs and banners as resources #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These resources are not currently countable, the api/v2/banners/count returns a 404. |
|
Travis doesn't like you 😄 |
|
Travis doesn't like me and I have some incorrect things in the resource files and the banner example that I saw after I submitted the PR |
| Bigcommerce.configure do |config| | ||
| config.auth = 'legacy' | ||
| # You will get this url when registering for an API key | ||
| config.url = ENV.fetch['BC_STORE_HASH'] |
There was a problem hiding this comment.
These should probably be (), as fetch is a method call.
So you can do it either as
ENV.fetch 'BC_STORE_HASH'
or
ENV.fetch('BC_STORE_HASH')
PreciselyAlyss
changed the title
|
Still need to add documentation/comments with options for enum fields to examples. |
PreciselyAlyss
force-pushed
the
0.1.0
branch
2 times, most recently
from
699586d to
cc1e127
Compare
|
👍 💚 |
xyzjace
changed the title
xyzjace
added a commit
that referenced
this pull request
Sep 11, 2015
Add gift certs and banners as resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the ruby gem to add gift certificates and banners as resources.