-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete rewrite of Bigcommerce API Client. #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pedelman
commented
Mar 16, 2015
- Bump major version to 1.0.0
- Introduces a new configuration syntax
- Support for domain objects
- Support for both legacy and oauth authentication
- Add comprehensive examples
- Add complete testing coverage
- Add complete resource coverage from developer documentation
- Add support for parsing server errors
- And much more!
@@ -1,10 +1,14 @@ | |||
language: ruby | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💁 Also recommend adding cache: bundler
in here as well, which will also speed up tests.
@uri = uri | ||
end | ||
|
||
def build(keys = []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs documentation.
- Bump major version to 1.0.0 - Introduces a new configuration syntax - Support for domain objects - Support for both legacy and oauth authentication - Add comprehensive examples - Add complete testing coverage - Add complete resource coverage from developer documentation - Add support for parsing server errors - And much more!
gregory
added a commit
that referenced
this pull request
Mar 17, 2015
Complete rewrite of Bigcommerce API Client.
nice job @pedelman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.