Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete rewrite of Bigcommerce API Client. #89

Merged
merged 1 commit into from
Mar 17, 2015
Merged

Complete rewrite of Bigcommerce API Client. #89

merged 1 commit into from
Mar 17, 2015

Conversation

pedelman
Copy link
Contributor

  • Bump major version to 1.0.0
  • Introduces a new configuration syntax
  • Support for domain objects
  • Support for both legacy and oauth authentication
  • Add comprehensive examples
  • Add complete testing coverage
  • Add complete resource coverage from developer documentation
  • Add support for parsing server errors
  • And much more!

@mattolson
Copy link
Contributor

excited

@@ -1,10 +1,14 @@
language: ruby

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💁 Also recommend adding cache: bundler in here as well, which will also speed up tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+38.13%) to 99.9% when pulling 0e87c4d on pedelman:version-1.0.0 into 095245a on bigcommerce:master.

@uri = uri
end

def build(keys = [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs documentation.

- Bump major version to 1.0.0
- Introduces a new configuration syntax
- Support for domain objects
- Support for both legacy and oauth authentication
- Add comprehensive examples
- Add complete testing coverage
- Add complete resource coverage from developer documentation
- Add support for parsing server errors
- And much more!
gregory added a commit that referenced this pull request Mar 17, 2015
Complete rewrite of Bigcommerce API Client.
@gregory gregory merged commit b7ce286 into bigcommerce:master Mar 17, 2015
@gregory
Copy link
Contributor

gregory commented Mar 17, 2015

nice job @pedelman !

@coveralls
Copy link

Coverage Status

Coverage increased (+38.13%) to 99.9% when pulling d420637 on pedelman:version-1.0.0 into 095245a on bigcommerce:master.

@mattolson
Copy link
Contributor

slow_clap_360 png

@splittingred
Copy link
Member

wooot

👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants