Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(core): adjust flakey tests #1340

Merged
merged 1 commit into from
Sep 6, 2024
Merged

test(core): adjust flakey tests #1340

merged 1 commit into from
Sep 6, 2024

Conversation

chanceaclark
Copy link
Contributor

@chanceaclark chanceaclark commented Sep 5, 2024 •
edited
Loading

What/Why?

  • Runs customer specific tests in serial mode as logging in will eventually rotate sessions failing currently running tests.
  • Added a function to help wait for the shipping section to render before playwright fills out the form.
  • Sequentially fill in the shipping form to mimic a shopper.
  • Matched the email addresses with the first and last name that is autogenerated.
  • Moved the mobile checkout test into a combined file, deduplicating some logic and adding stability.
  • Simplified breadcrumbs test.

Testing

Ran the regression tests a few times locally and passed every time.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 013be40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 9:41pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 9:41pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 9:41pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 9:41pm
catalyst-staging ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 9:41pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 9:41pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 9:41pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 9:41pm

@chanceaclark chanceaclark changed the title test(core): adjust customer specific tests test(core): adjust flakey tests Sep 5, 2024
@chanceaclark chanceaclark marked this pull request as ready for review September 5, 2024 21:45
@chanceaclark chanceaclark requested a review from a team as a code owner September 5, 2024 21:45
jorgemoya
jorgemoya approved these changes Sep 5, 2024
View reviewed changes
core/tests/ui/desktop/core/components/breadcrumbs.spec.ts
.getByRole('navigation', { name: 'Main' })
.getByRole('link', { name: 'Kitchen' })
.hover();
await page.goto('/kitchen/knives/most-popular/');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@chanceaclark chanceaclark added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit d3df74f Sep 6, 2024
14 checks passed
@chanceaclark chanceaclark deleted the tests/rework-checkout-tests branch September 6, 2024 00:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-idx90ffjc-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgemoya jorgemoya jorgemoya approved these changes

@deini deini deini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanceaclark @jorgemoya @deini