Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): enforce use of next-intl's navigation APIs #1361

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Noticed we were not using next-intl's wrapper navigation APIs.

  • Added eslint rule to enforce use of these APIs.
  • Fixed issues.

Testing

Locally, behaves the same.

@jorgemoya jorgemoya requested a review from a team as a code owner September 12, 2024 17:58
Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 754585d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 3:45pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Sep 13, 2024 3:45pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 3:45pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 3:45pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 3:45pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 3:45pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 3:45pm

@jorgemoya
Copy link
Contributor Author

Investigating how to prevent redirect to append locale on default locale.

@jorgemoya
Copy link
Contributor Author

jorgemoya commented Sep 12, 2024

Investigating how to prevent redirect to append locale on default locale.

Opened an issue for this: amannn/next-intl#1335.

Will need to expect locale prefix when using redirect until a solution is found.

core/.eslintrc.cjs Outdated Show resolved Hide resolved
@jorgemoya jorgemoya added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit dd10d06 Sep 13, 2024
13 checks passed
@jorgemoya jorgemoya deleted the use-next-intl-exports branch September 13, 2024 16:35
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-ukvgbqxup-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants