-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): enforce use of next-intl's navigation APIs #1361
Conversation
🦋 Changeset detectedLatest commit: 754585d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
2733688
to
21f9ebc
Compare
21f9ebc
to
c87348c
Compare
Investigating how to prevent |
Opened an issue for this: amannn/next-intl#1335. Will need to expect locale prefix when using |
7646b9c
to
754585d
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-ukvgbqxup-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
Noticed we were not using next-intl's wrapper navigation APIs.
Testing
Locally, behaves the same.