Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add missing metadata in account home page #1373

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Missing metadata, use translated message.

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner September 16, 2024 16:36
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 6:45pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Sep 16, 2024 6:45pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:45pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:45pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:45pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:45pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:45pm

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 89314df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jorgemoya jorgemoya force-pushed the add-metadata-home-settings branch from cfc4677 to 89314df Compare September 16, 2024 18:42
@jorgemoya jorgemoya added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 971033f Sep 16, 2024
13 checks passed
@jorgemoya jorgemoya deleted the add-metadata-home-settings branch September 16, 2024 19:00
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-i6kcs68z0-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants