Wishlist Sheet on Product Card #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a28e9a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
yurytut1993
force-pushed
the
wishlist-sheet-on-product-card
branch
from
096ceea
to
333384a
Compare
yurytut1993
force-pushed
the
wishlist-sheet-on-product-card
branch
from
333384a
to
fd9e9a1
Compare
yurytut1993
force-pushed
the
wishlist-sheet-on-product-card
branch
from
fd9e9a1
to
1048c1d
Compare
yurytut1993
force-pushed
the
wishlist-sheet-on-product-card
branch
from
1048c1d
to
834138f
Compare
yurytut1993
force-pushed
the
wishlist-sheet-on-product-card
branch
from
834138f
to
ed88ba8
Compare
core/app/[locale]/(default)/(faceted)/category/[slug]/page-data.ts
Outdated
Show resolved
Hide resolved
yurytut1993
force-pushed
the
wishlist-sheet-on-product-card
branch
from
ed85c17
to
8ac8316
Compare
yurytut1993
force-pushed
the
wishlist-sheet-on-product-card
branch
from
8ac8316
to
9cebf31
Compare
| @@ -8,7 +8,7 @@ import { graphql, VariablesOf } from '~/client/graphql'; | |||
| import { revalidate } from '~/client/revalidate-target'; | |||
| import { BreadcrumbsFragment } from '~/components/breadcrumbs/fragment'; | |||
|
|
|||
| import { WishlistSheetFragment } from '../../account/(tabs)/wishlists/_components/wishlist-sheet/fragment'; | |||
| import { WishlistSheetFragment } from '../../../../../components/wishlist-sheet/fragment'; | |||
There was a problem hiding this comment.
dont forget to rewrite here as well)
yurytut1993
force-pushed
the
wishlist-sheet-on-product-card
branch
from
9cebf31
to
a28e9a6
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-breo6tuqt-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This pr adds Wishlist Sheet on Product Card
Also, as Wishlist Sheet now used not only in Account scope, component was replaced
wishlist-sheet-on-plp.mov
Testing
Locally