-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wishlist Sheet on Product Card #1474
Conversation
🦋 Changeset detectedLatest commit: a28e9a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
096ceea
to
333384a
Compare
333384a
to
fd9e9a1
Compare
fd9e9a1
to
1048c1d
Compare
1048c1d
to
834138f
Compare
834138f
to
ed88ba8
Compare
core/app/[locale]/(default)/(faceted)/category/[slug]/page-data.ts
Outdated
Show resolved
Hide resolved
ed85c17
to
8ac8316
Compare
8ac8316
to
9cebf31
Compare
@@ -8,7 +8,7 @@ import { graphql, VariablesOf } from '~/client/graphql'; | |||
import { revalidate } from '~/client/revalidate-target'; | |||
import { BreadcrumbsFragment } from '~/components/breadcrumbs/fragment'; | |||
|
|||
import { WishlistSheetFragment } from '../../account/(tabs)/wishlists/_components/wishlist-sheet/fragment'; | |||
import { WishlistSheetFragment } from '../../../../../components/wishlist-sheet/fragment'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont forget to rewrite here as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
9cebf31
to
a28e9a6
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-breo6tuqt-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
This pr adds Wishlist Sheet on Product Card
Also, as Wishlist Sheet now used not only in Account scope, component was replaced
wishlist-sheet-on-plp.mov
Testing
Locally