Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add better slides to the carousel #1497

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

chanceaclark
Copy link
Contributor

What/Why?

Adds better looking slides to the carousel.

Testing

Screenshot 2024-10-21 at 17 08 40
Screenshot 2024-10-21 at 17 08 44
Screenshot 2024-10-21 at 17 08 49

@chanceaclark chanceaclark requested a review from a team as a code owner October 21, 2024 21:10
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: be61cd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 7:05pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Oct 22, 2024 7:05pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:05pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:05pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:05pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:05pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:05pm

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-5jaeqjcau-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 75
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 79
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 85

Merged via the queue into main with commit 12ce1d7 Oct 22, 2024
13 checks passed
@chanceaclark chanceaclark deleted the fix/slides branch October 22, 2024 19:08
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
bookernath added a commit that referenced this pull request Oct 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants