Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set image priority #1504

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Set image priority #1504

merged 1 commit into from
Oct 22, 2024

Conversation

bookernath
Copy link
Contributor

What/Why?

Set image priority on carousel; only prioritize first image

Testing

Resolves lighthouse issue on preview build

@bookernath bookernath requested a review from a team as a code owner October 22, 2024 23:17
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 29bf0b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 11:21pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Oct 22, 2024 11:21pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 11:21pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 11:21pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 11:21pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 11:21pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 11:21pm

@bookernath bookernath added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit ef64ed5 Oct 22, 2024
13 checks passed
@bookernath bookernath deleted the set-image-priority branch October 22, 2024 23:28
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-oenbwz9y3-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants