Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update login page & error message styles #1505

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

bc-alexsaiannyi
Copy link
Contributor

What/Why?

This PR updates layout & styles for Login page that include:

  • reducing size for heading,
  • reduce margin bootom,
  • center "Forgot password" button on mobile

Also it unites message size & colour for error validation on form fields.

Testing

locally

login.page.mov

@bc-alexsaiannyi bc-alexsaiannyi requested a review from a team as a code owner October 23, 2024 08:44
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: b296184

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 9:21am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Oct 25, 2024 9:21am
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 9:21am
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 9:21am
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 9:21am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 9:21am
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 9:21am

@chanceaclark
Copy link
Contributor

Make sure to add a changeset

@bc-alexsaiannyi bc-alexsaiannyi added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 691ec2b Oct 25, 2024
12 of 13 checks passed
@bc-alexsaiannyi bc-alexsaiannyi deleted the fix-login-page branch October 25, 2024 10:32
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-pd8b9uxue-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants