fix(core): improve account settings form #1506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 866b86c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
chanceaclark
approved these changes
Oct 23, 2024
|
Make sure to update the functional test suite, but otherwise looks good. |
jorgemoya
approved these changes
Oct 23, 2024
bc-alexsaiannyi
approved these changes
Oct 24, 2024
bc-azvierieva
force-pushed
the
improve-account-settings-form
branch
from
e3fcc14
to
266621d
Compare
bc-azvierieva
force-pushed
the
improve-account-settings-form
branch
from
266621d
to
866b86c
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-1pmxma8wa-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR improves account settings form, namely it removes unnecessary fields.
Also this PR updates settings confirmation message.
Testing
locally
before:
improve_account_settings_form_before.mov
after:
improve_account_settings_form_after.mov
with custom field:
improve_account_settings_form_custom_field.mov