feat(core): remove account status provider with toast messages #1749
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
| @@ -35,5 +35,5 @@ test('Account is not created if email is already in use', async ({ page, account | |||
|
|
|||
| await page.getByRole('button', { name: 'Create account' }).click(); | |||
|
|
|||
| await expect(page.getByText('The email address is already in use.')).toBeVisible(); | |||
There was a problem hiding this comment.
I just had to fix an issue in the wordpress issue, but this is a security concern allowing bad actors find out if email addresses are valid. Changed it over to a more generic error.
chanceaclark
changed the title
chanceaclark
force-pushed
the
feat/auth-toast
branch
from
cf4c191 to
005d7aa
Compare
🦋 Changeset detectedLatest commit: 005d7aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-6gsjqvwr8-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
Remove the rest of the account status provider usages and move over to using toasts.
I also had to adjust a few things for all the pages to work correctly:
loginroute was statically generated, which prevented an auth check on the page. Needed to remove that static generation.Testing
Updated and ran the test suite to verify all functionality worked the same.